PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.83k stars 1.63k forks source link

[BUG]: Klonoa 2 - White flash after cutscene in Momett House when using software #7884

Closed Toastarrr closed 1 year ago

Toastarrr commented 1 year ago

Describe the Bug

Visiting Momett House after collecting enough dolls to unlock a new level or feature will play a brief cutscene. On software, this cutscene makes the screen flash white after ending.

The cutscene ends normally on hardware.

Reproduction Steps

Visit Momett House after collecting enough dolls to unlock something.

Expected Behavior

The screen should fade to black, then fade back in.

PCSX2 Revision

PCSX2 Nightly - v1.7.3900

Operating System

Windows 10 (64bit)

If Linux - Specify Distro

No response

CPU

AMD Ryzen 5 2600X Six-Core Processor

GPU

4095MB NVIDIA GeForce GTX 1080

GS Settings

Software Renderer

Emulation Settings

No response

GS Window Screenshots

whiteflashscreenshot

Logs & Dumps

Google Drive link to GS dump emulog.txt

Toastarrr commented 1 year ago

Trying to record this bug using Nvidia ShadowPlay in fullscreen causes the recording to abruptly end and save when the white flash happens.

I don't know exactly what's happening under the hood, but it seems like something in PCSX2 is getting "reset" when this bug occurs.

refractionpcsx2 commented 1 year ago

Can you re-enable extra + sign clamping on VU1 and see if it resolves it? if so I'll put it back on.

Toastarrr commented 1 year ago

Changing VU1 Clamping Mode to "Extra + Preserve Sign" does not resolve it.

refractionpcsx2 commented 1 year ago

is it resolved if you put it in software mode (F9)?

Toastarrr commented 1 year ago

The bug still happens in software mode. It doesn't happen in hardware regardless of VU1 Clamping setting.

Toastarrr commented 1 year ago

This seems related. There are several other places in the game where a fade-to-black briefly flashes an incorrect frame at the end when using software. Here's two that I found:

https://user-images.githubusercontent.com/68636505/212549584-c41b7105-cf4b-4fa4-b14c-851f38fd6625.mp4

https://user-images.githubusercontent.com/68636505/212549647-39c541a3-b647-443b-a259-87aa7dd17e39.mp4

https://user-images.githubusercontent.com/68636505/212550121-2a3ad436-63cd-49b4-b916-288fc1b2a4f5.mp4

https://user-images.githubusercontent.com/68636505/212550122-249b9e65-d193-430d-a712-5b8c0fc801bc.mp4

refractionpcsx2 commented 1 year ago

can you record a multiframe GS Dump of one of these transitions? that might be useful.

The hotkeys (which you hold down for the recording period) should be R-Ctrl + R-Shift + F8, but you can modify it in the hotkeys, if you want something easier.

Toastarrr commented 1 year ago

Here's a GS dump made while using software mode. GSdump.zip

What's strange is that the dump file doesn't show the flash even though I saw it while recording. It's the same with the GS dump I posted yesterday.

refractionpcsx2 commented 1 year ago

well, that's annoying...

refractionpcsx2 commented 1 year ago

Okay so is there an easy point from a memcard save we can go to in order to reproduce it? along with some instructions (remember the likelyhood is none of us have played this game)

Toastarrr commented 1 year ago

The fastest way I know to encounter it is to select Claire Moa Temple from the map, beat the boss by picking up enemies (Square) and throwing them (Square) at the flashing weak point, and then making a save state so you can replay the cutscene at the end.

It's a very short and easy boss, so it's hopefully not too much of a problem. Mcd001.zip

ClaireMoaTemple

refractionpcsx2 commented 1 year ago

alright, thanks :)

Toastarrr commented 1 year ago

I've discovered you don't even need to go further than the title screen to see the screen flash white after a fade-to-black

https://user-images.githubusercontent.com/68636505/212667013-148173ef-52f4-4b69-9cf4-b2b4872d2f6b.mp4

https://user-images.githubusercontent.com/68636505/212667019-1b30e3a2-e61e-46dc-b8c9-6fd70585575c.mp4

I discovered the title screen flash while creating a save where the Momett House issue I described in the first post can be seen.

Mcd001.zip To reproduce the bug described at the top of this thread, select Momett House from the map and watch the cutscene in software mode. The Claire Moa Temple instance can also be seen using this save by following the steps in my last post. MomettHouse

refractionpcsx2 commented 1 year ago

I replicated it on the US version by letting the intro run. Using an Nvidia 2080Ti, so it's not an AMD issue. Also it's a software renderer, so it's very unlikely to be vendor specific.

refractionpcsx2 commented 1 year ago

oh right.. hmm, well I do have a Ryzen CPU. But it seems highly unlikely still.

Toastarrr commented 1 year ago

This appears to be fixed on the newest build. Not sure what did it, though. Can you still replicate this @refractionpcsx2 ?

refractionpcsx2 commented 1 year ago

Can confirm it was fixed by #8014, nice :)