search

PCSX2 / pcsx2

PCSX2 - The Playstation 2 Emulator
https://pcsx2.net
GNU General Public License v3.0
11.85k stars 1.63k forks source link

[BUG]: Gran Turismo 4 - Reward screen trophies have no reflection on D3D/OpenGL #9753

Closed TamiyaGuy closed 1 year ago

TamiyaGuy commented 1 year ago

Describe the Bug

When using D3D11, D3D12 or OpenGL hardware renderers, the trophy in the results screen has no reflections. This happens with Blending Accuracy set to Basic - Maximum, but not Minimum. HW hacks do not seem to affect the issue. Other reflections (e.g. car reflections

This issue has only appeared recently in the nightly builds - I can't pinpoint which version showed the change, but definitely within the last two weeks.

Reproduction Steps

Win a race with the Renderer set to D3D11/D3D12/OpenGL and Blending Accuracy at anything except Minimum.

Expected Behavior

The trophy should have a reflection on it (as seen in Vulkan or Software renderers)

PCSX2 Revision

v1.7.4892

Operating System

Windows 10 (64bit)

If Linux - Specify Distro

No response

CPU

i7-7700k

GPU

GTX 1070

GS Settings

No response

Emulation Settings

EE Clamping Mode: Full

GS Window Screenshots

image

Logs & Dumps

No response

Mrlinkwii commented 1 year ago

can i have a gs dump?

TamiyaGuy commented 1 year ago

Sure thing, thanks!

Gran Turismo 4_SCUS-97328_Results_Screen_Trophy.zip

lightningterror commented 1 year ago

Regression from https://github.com/PCSX2/pcsx2/pull/9196

lightningterror commented 1 year ago

Game does accumulation blend Cs*128 + Cd, rt alpha min max are both 128, this worked on vulkan by chance (maybe?) because we were still reading the RT without any barriers. We shouldn't be reading the RT in this case since we know what Ad will be.