search

PCSX2 / pcsx2_patches

Patches for Widescreen, No Interlace etc go in here, syncs with the main repo
125 stars 66 forks source link

Invalid Widescreen patch line for Spyro: A Hero's Tail #303

Closed Daniel-McCarthy closed 4 months ago

Daniel-McCarthy commented 5 months ago

Description:

For "Spyro: A Hero's Tail" SLUS-20884_94C56923.pnach and SLES-52569_6E51213C.pnach, the widescreen patches have a broken patch line that will not be loaded due to using patch=3 which is not a valid option as per Patch.cpp.

The behavior is simply that the line gets ignored as if it doesn't exist. Since the 3 patch lines use this field as a "patch number", they put each line as 1,2,3, so all 3 lines need to be updated to 0, 1, or 2 depending on what is most appropriate for this patch.

//Widescreen + Extra Perspective
patch=1,EE,003B28C8,extended,3C013F10
patch=2,EE,003B28DC,extended,3C013F10
patch=3,EE,003B2F08,extended,3C013EC0

As I don't have this game, I can't test the impact of the change so am reporting instead of submitting a PR to fix it.

Mrlinkwii commented 4 months ago

i managed to test the us version , with the patch=3,EE,003B2F08,extended,3C013EC0 removed , i saw no difference and nothing broke image