search

PCSX2 / pcsx2_patches

Patches for Widescreen, No Interlace etc go in here, syncs with the main repo
125 stars 66 forks source link

Debugging my 60fps patches and fix God of War in widescreen #310

Closed PeterDelta closed 4 months ago

PeterDelta commented 4 months ago

I have debugging the patches that I made in progressive, in most of them no noticeable change will be noticed and in a few the image is perfectly centered, which is what I had left to do.

In God of War: Fixed flames on the title screen in all languages. In English they were eliminated and will now be seen

God of War_SCES-53133_20240207001610 God of War_SCES-53133_20240207001643 God of War_SCES-53133_20240207001615 God of War_SCES-53133_20240207001638

refractionpcsx2 commented 4 months ago

Did you mess up a rebase? There seems to be a lot more edited than just god of war here.

PeterDelta commented 4 months ago

Take advantage of the pull to include everything together. everything is tested

refractionpcsx2 commented 4 months ago

There seems to be a few 480p patches there you renamed to 60FPS, maybe it'd be better to call them 480p 60FPS for completeness and accuracy.

PeterDelta commented 4 months ago

There seems to be a few 480p patches there you renamed to 60FPS, maybe it'd be better to call them 480p 60FPS for completeness and accuracy.

I understand but the one that enables 480p only does that, if the game runs at 30/60, by naming them as 480p 60 FPS the average user may be confused by not running 60/60 (for that they have to enable the other one that unlocks internal fps). That's why I changed the description of the so-called 50 FPS indicating that it unlocks the FPS without specifying 50 or 60. I have thought about that and I have considered that this way there is less confusion, I also thought of putting it together to enable 480p and also the fps and not having to activate the two patches called 50 FPS and 60 FPS, but several comments in other Pulls indicated that the patches should be separate. One for FPS and another for video mode, in this case 480p. In other games they run with unlocked FPS, I have called them "480p Mode" and in the description it indicates that they run at 60fps. My intention is that they all have the same name and with just a glance you know what to activate. Another interesting option I had in mind would be to rename the one that unlocks the fps called 50 FPS as Unlock FPS so there would be no confusion about what it does. What do you think is the best option? I have no problem changing them all.

refractionpcsx2 commented 4 months ago

Unlock would make more sense if you don't want to give promises of 60 FPS, which calling it 60 FPS does. But also the game is being forced in to a progressive 480p mode, which I think is important to mention, it's not just an fps change.

refractionpcsx2 commented 4 months ago

Also did you mean to close this?

PeterDelta commented 4 months ago

Also did you mean to close this?

No! When creating a new pull, the github desktop has been tangled and deleted, no problem, I'll reorganize them as you say. I'll put [Unlock FPS] for the one that unlocks the fps and rename the other one as [480p Mode]. If you see a better way, feel free to tell me.

refractionpcsx2 commented 4 months ago

Alright, I can live with that, thanks :) I just wanted to be verbose about what it's actually doing :)