Remove unnecessary No-Interlacing patches

PCSX2 / pcsx2_patches

Patches for Widescreen, No Interlace etc go in here, syncs with the main repo

125 stars 66 forks source link

Remove unnecessary No-Interlacing patches #324

Closed PeterDelta closed 4 months ago

PeterDelta commented 4 months ago

As of this version: https://github.com/PCSX2/pcsx2/pull/10821 Patches can no longer be disabled per game. These types of patches that are only limited to eliminating the sceGsSetHalfOffset routine were a good fix in old versions but now they have become obsolete, do not improve anything and do worsen the textures and letters, so to keep the games with the least alteration I remove. following that I have verified are no longer necessary.

In Gran Turismo 3 we see that in automatic and the default interlacing modes of pcsx2 they do not act correctly so a patch would be needed. Gran Turismo 3 automatic

Old patch that eliminates the routine sceGsSetHalfOffset Gran Turismo 3 routine interlacing

New patch enables progressive interlacing, keeps the sceGsSetHalfOffset routine unchanged, the image does not shake and the scrolling of the letters looks correct. The difference is minimal but it is there. Gran Turismo 3 progressive

Mrlinkwii commented 4 months ago

patches can be disbled on a per game bases but you need to use teh patch menu

works here

refractionpcsx2 commented 4 months ago

What? I just removed the option to disable the per game settings, control to enable and disable patches per game is still there.

PeterDelta commented 4 months ago

I'm not talking about game settings, that works fine. I am referring specifically to the option for Non-Interlacing patches. I understand the reason why that option is removed, but when the option to activate them globally is enabled, the patches that only eliminate the sceGsSetHalfOffset routine are not good. Making a comparison with and without a pcsx2 patch wins by having the automatic option, I hope I have explained myself well

refractionpcsx2 commented 4 months ago

Then the patches should be fixed. But I am aware you either enable them globally or only per game, there's no exception option. We've been discussing that.

The reason I said that was because you linked to my pr removing the option to disable per game settings, which is not the same thing.

PeterDelta commented 4 months ago

I expressed myself incorrectly, sorry. As I say, I completely understand why this change was made, you have done a great job with the interlacing of pcsx2 and these types of patches are no longer necessary.

refractionpcsx2 commented 4 months ago

Alright, cool thanks