search

PCSX2 / pcsx2_patches

Patches for Widescreen, No Interlace etc go in here, syncs with the main repo
125 stars 65 forks source link

Allow the Ratchet and Clank Widescreen Patch #367

Closed ghost closed 1 month ago

ghost commented 1 month ago

Description

I am proposing to allow the widescreen patch for Ratchet and Clank.

The widescreen patch for Ratchet and Clank is unavailable to use.

The file is "SCUS-97199_CE4933D0.pnach".

The following is the comment in the patch file:

"Widescreen hack by PsxFan107. Currently it appears to break rendering of textures in some areas."

I edited the patch to allow it to work in the game. I played through sections of the game and I did not notice any notable texture issues as described in the comment.

URL: https://github.com/sandboxgamedev123/Ratchet-and-Clank-Widescreen

The URL refers to a repository I created that provides the edited patch file as well as additional information. I copied the code to the existing file in the "pcsx2_patches" repository.

Reason

The widescreen patch allows the game to operate with a 16:9 aspect ratio in-game.

Checklist

The test systems:

refractionpcsx2 commented 1 month ago

Can you show this area with your patch? I'm not quite sure which one it is https://github.com/PCSX2/pcsx2_patches/pull/74

refractionpcsx2 commented 1 month ago

Come on mate, we're not fucking stupid. You just re-enabled the old patch, I can compare files, you know. Stop wasting our time.

image

ghost commented 1 month ago

I did not state the patch code was different. I stated that the patch was edited to allow it to work in-game. I did not state that I fixed an aspect of the patch code or improved the patch code. The title of the pull request is "Allow the Ratchet and Clank Widescreen Patch".

I was in the area from the link you provided and the area did not look like the image. There was occasional flickering on the foliage but I do not know if it is a LOD issue or texture issue. I think it is much more minor than what was shown in the image. And as I mentioned before, I tested sections of the game on two systems and I think it generally looked as it should. I was noticing texture detail transitions near that area. I am referring to a 2002 game operating in HD so flaws in the game engine might be more noticeable. I think the issues were very minor.

I will provide screenshots of the area.

I used the Vulkan renderer. I do not know if other renderers produce issues. Regardless, I think Vulkan is important for operating the emulator on modest hardware so the other renderers could be considered less relevant.

refractionpcsx2 commented 1 month ago

There's no point checking it now, it's the same patch, it's still going to be broken. I'm not accepting it, it is broken.

ghost commented 1 month ago

Why do you believe it is broken? It does not look broken to me. How many people reported issues with it? Even if there are a few issues with it, that does not mean it is broken. I think it may be a net improvement for the project to have the patch available. The patch is optional and not enabled by default.

refractionpcsx2 commented 1 month ago

We had several people report issues with it, to the point we looked in to it and discovered it was the patch. We haven't had a single report since disabling it.

ghost commented 1 month ago

The following are images from PCSX2 v1.7.5858 on a system with an AMD Ryzen 5 5600H and a NVIDIA GeForce RTX 3060 using the Vulkan renderer.

As I think you can see, I think the game generally looks as it should. If you would like I can conduct the test again with the AMD Radeon Vega 7 integrated GPU, or the Intel Core i5-7300HQ CPU with the Intel HD Graphics 630 integrated GPU or the NVIDIA GeForce GTX 1050 Ti.

Since the patch generally works well on my range of hardware but yet you saw reports from several people regarding the patch, I am wondering if it is not specifically an issue with the patch. The GPU API commonality with my hardware is Vulkan 1.3 support. I am wondering if the issue is related to the renderer being used or GPU API compatibility.

I am also wondering if the issue was already fixed from updates to the emulator. What was the newest report you received? I have been using PCSX2 again since v1.7.5290 and I did not notice the issue in v1.7.4721 either.