PCSX2 / pcsx2_patches

Patches for Widescreen, No Interlace etc go in here, syncs with the main repo
125 stars 65 forks source link

Urban Reign (NTSC) SLUS-212.09 - Deinterlacing & De-Blur Patches #370

Open Joshua-1248 opened 1 month ago

PeterDelta commented 1 month ago

Please, could you share a screenshot of each game with the patch enabled and another with the default pcsx2 options?, so we can see if there is improvement or if it gets worse. Basically you are removing the sceGsSetHalfOffset routine and in the latest versions of pcsx2 in most games the image does not shake and runs fine, therefore removing those values ​​makes the image look worse. https://github.com/PCSX2/pcsx2_patches/pull/353

Joshua-1248 commented 1 month ago

Please, could you share a screenshot of each game with the patch enabled and another with the default pcsx2 options?, so we can see if there is improvement or if it gets worse. Basically you are removing the sceGsSetHalfOffset routine and in the latest versions of pcsx2 in most games the image does not shake and runs fine, therefore removing those values ​​makes the image look worse. #353

These patches are different from NOP'ing the sceGsSetHalfOffset instruction routine as they are placed next to the interlacing address in memory that cycles in value between 0 and 1, & back to 0 & then 1 again.

There happened to be two settings there that I could just switch the value of to zero to disable not only the interlacing, but the screen blur.

De-Blur Patch:

Before: Urban Reign_SLUS-21209_20240603152812 After: Urban Reign_SLUS-21209_20240603152817

PeterDelta commented 4 weeks ago

Well, I am only referring to the patches named as "Deinterlacing Patch" or "No-Interlacing" to see if there is improvement or not.

pgert commented 4 weeks ago

Upload the pnachs directly to the 'patches' folder of the repo. Don't have a 'cheats_ni' folder in which you put them.

If a pnach already exists for the disc, then download the repo as a zip-folder, extract and find the pnach, add the hack to that pnach, and upload that pnach.

Don't have "//Deinterlacing Patch" or "//Deinterlacing Code" entries. Make them hacks that can be turned on/off, as in "[Deinterlacing Patch]" & "[Deinterlacing Code]".

BetterWarrior commented 1 week ago

Thank you Joshua, for this patch it's really a game changer i was tired of trying to fix the game i tried x8 resolution i tried all deinterlacing methods for the game, i even tried x8 upscale of the game but it was blurry and shaken but with your patch the game look really incredible.

Mrlinkwii commented 1 week ago

whats the status of the pr?