PCSX2 / pcsx2_patches

Patches for Widescreen, No Interlace etc go in here, syncs with the main repo
158 stars 75 forks source link

Allow the Ratchet and Clank Widescreen Patch #373

Closed ghost closed 3 months ago

ghost commented 3 months ago

It is possible that the previous pull request was closed prematurely.

This is based on the following issue:

https://github.com/PCSX2/pcsx2/issues/11321

This is also based on the following pull request:

https://github.com/PCSX2/pcsx2_patches/pull/367

Checklist

Operating systems tested:

Test systems:

The following is the most recent comment from the previous pull request:

The following are images from PCSX2 v1.7.5858 on a system with an AMD Ryzen 5 5600H and a NVIDIA GeForce RTX 3060 using the Vulkan renderer.

As I think you can see, I think the game generally looks as it should. If you would like I can conduct the test again with the AMD Radeon Vega 7 integrated GPU, or the Intel Core i5-7300HQ CPU with the Intel HD Graphics 630 integrated GPU or the NVIDIA GeForce GTX 1050 Ti.

Since the patch generally works well on my range of hardware but yet you saw reports from several people regarding the patch, I am wondering if it is not specifically an issue with the patch. The GPU API commonality with my hardware is Vulkan 1.3 support. I am wondering if the issue is related to the renderer being used or GPU API compatibility.

I am also wondering if the issue was already fixed from updates to the emulator. What was the newest report you received? I have been using PCSX2 again since v1.7.5290 and I did not notice the issue in v1.7.4721 either.

Mrlinkwii commented 3 months ago

you didnt fix anything , it literally the same patch

ghost commented 3 months ago

I did not say the patch code was different. The title says "Allow the Ratchet and Clank Widescreen Patch".

refractionpcsx2 commented 3 months ago

I did not say the patch code was different. The title says "Allow the Ratchet and Clank Widescreen Patch".

image

That sounds like you modified it to work, since it was disabled for being broken.

Anyways, we're looking in to it, we have reproduced the error again, but it may not be directly related to the patch, but the widescreen patch does make it worse.

ghost commented 3 months ago

I did modify the patch to remove the comments to allow it to work in the game. But the patch code is the same. My intention was not to mislead anyone.

As I mentioned before, the issue might not be the patch but a renderer or hardware compatibility with a renderer.