search

PCSX2 / pcsx2_patches

Patches for Widescreen, No Interlace etc go in here, syncs with the main repo
158 stars 75 forks source link

Maken Shao PAL (SLES-51058_54854C71) no interlacing code forces NTSC 60 FPS profile and immediately desyncs all FMVs #380

Closed Wiinansa closed 2 months ago

Wiinansa commented 3 months ago

The Maken Shao patch provides a no-interlacing code but pushes a PAL Interlaced format into a NTSC Progressive format, making it into a 60 FPS game too. It desyncs every FMV by playing them too fast and considering every cutscene is pre-rendered, this pretty much makes the story impossible to follow.

The description of the no-interlacing code doesn't provide any mention of a 60 FPS framerate mode coming with the no-interlacing option. I think this will make it a worse experience for players to leave it as is

[No-Interlacing]
gsinterlacemode=1
comment=Progressive scan

//Override SetGsCrt syscall arguments.
patch=1,EE,202000c0,extended,24040000
patch=1,EE,202000c4,extended,24050002
patch=1,EE,202000c8,extended,24060001

Removing the second line patch=1,EE,202000c4,extended,24050002 brings it back to a PAL Progressive format and removes the 60 FPS NTSC format stuck in there. As long as FMVs remain desynced without an included fix, I think this line should be removed from the patch and have a more accurate comment description to users. Sorry I'm not familiar enough to make the fixes myself