search

PCSX2 / pcsx2_patches

Patches for Widescreen, No Interlace etc go in here, syncs with the main repo
167 stars 75 forks source link

WS: Disable CID the Dummy SLUS-21754 WS patch #409

Closed Goatman13 closed 2 months ago

Goatman13 commented 2 months ago

Patch is working (need to be enabled before running the game), but it is creating branch in branch delay slot. image

[   48.1423] Enabled patch: Widescreen 16:9
[   48.1431]   1,EE,word,00228aa0,8030000
[   48.1438]   1,EE,word,000c0000,46000586
[   48.1443]   1,EE,word,000c0004,3c013faa
[   48.1447]   1,EE,word,000c0008,3421aaab
[   48.1452]   1,EE,word,000c000c,4481f000
[   48.1456]   1,EE,word,000c0010,461eb582
[   48.1460]   1,EE,word,000c0014,808a2a9
[   48.1467] OSD [LoadPatches]: 1 game patches are active.
[   48.1470] Applying settings...
[   48.1476] Patch: Setting aspect ratio to 16:9 by patch request.
[   48.1481] Updating GS configuration...
[   48.1792] Branch c09317a in delay slot!
[   48.2457] Branch c09317a in delay slot!

closes #406

Goatman13 commented 2 months ago

I updated description because it turns out that patch is working, but instruction at 0x228AA4 will be skipped at all.

Edit: In case that i'm wrong and pcsx2 don't ignore branches/jumps in delay slots or this is no problem for some other reason, please close this PR and related issue.

PeterDelta commented 2 months ago

It's not a problem, is the patch working well or not? I mean, if there are some glitches in the textures, the perspective is not correct, etc...

Goatman13 commented 2 months ago

Ok then, since patch is working i will close this...

ghost commented 1 month ago

It's not a problem, is the patch working well or not? I mean, if there are some glitches in the textures, the perspective is not correct, etc...

This could (in theory) create a TLB miss. It's best to jal to 0x000c0000 and then add 'j 0x0024C5E8' at 0x000c0014