search

PCSX2 / pcsx2_patches

Patches for Widescreen, No Interlace etc go in here, syncs with the main repo
168 stars 75 forks source link

Some deinterlacing patches #431

Closed NineKain closed 1 week ago

NineKain commented 1 month ago

Tested all of them, they work and look good

PeterDelta commented 1 month ago

Have you made comparisons of whether these patches are really necessary? Because they only make things worse in general. https://github.com/PCSX2/pcsx2_patches/pull/273

NineKain commented 1 month ago

I have made them because it looked better than base, but of course anyone can test and decide for themselves

PeterDelta commented 1 month ago

I have tested them and there are the tests, they look clearly worse

NineKain commented 1 month ago

How come? In my end they look sharp and stable, can you post some screenshots? Have you tried them in motion?

pgert commented 1 month ago

gametitle=Tsugunai: Atonement NTSC-U SLUS-20292 * 9D57694E

Suggestion: Try out this hack to see if it works better.

[Widescreen 16:9] gsaspectratio=16:9 patch=1,EE,0017cf94,word,3c013f40 // field // patch=1,EE,0018c1ac,word,3c013f40 // ? patch=1,EE,001c1f30,word,3c013f40 // battle patch=1,EE,001b7e28,word,3c013f40 // amulet patch=1,EE,001acb94,word,3c013f40 // + patch=1,EE,001ac534,word,3c013f40 // + patch=1,EE,001c1ea4,word,3c013f40 // strage attack

PeterDelta commented 1 month ago

Sure and many more, the result is always worse than if we compare it with the default options of pcsx2. Between the pull I posted at the beginning and these comparisons I show with and without the patch you publish, it is evident and noticeable.

Extermination_SCES-50240_20241012091742 pcsx2 default ↑

Extermination_SCES-50240_20241012091841 with with patch ↑

Extermination_SCES-50240_20241012091759 pcsx2 default 3x ↑

Extermination_SCES-50240_20241012091856 with with patch 3x Note the saw teeth ↑

Chulip_SLUS-20742_20241012092710 pcsx2 default Chulip_SLUS-20742_20241012092719 with with patch ↑

Chulip_SLUS-20742_20241012092804 pcsx2 default 3x ↑ Chulip_SLUS-20742_20241012092815 with with patch 3x Note the saw teeth in the tree and graphics 3d ↑

Tsugunai - Atonement_SLUS-20292_20241012095054 pcsx2 default ↑ Tsugunai - Atonement_SLUS-20292_20241012095122 with with patch ↑

Tsugunai - Atonement_SLUS-20292_20241012095206 3x pcsx2 default 3x ↑ Tsugunai - Atonement_SLUS-20292_20241012095149 3x with with patch 3x ↑

Tsugunai - Atonement_SLUS-20292_20241012095319 pcsx2 default ↑ Tsugunai - Atonement_SLUS-20292_20241012095424 with patch ↑

Tsugunai - Atonement_SLUS-20292_20241012095326 3x pcsx2 default 3x ↑ Tsugunai - Atonement_SLUS-20292_20241012095420 3x with with patch 3x ↑

Eternal Poison_SLUS-21779_20241012102712 pcsx2 default ↑ Eternal Poison_SLUS-21779_20241012102754 with with patch ↑

Eternal Poison_SLUS-21779_20241012094611 3x pcsx2 default 3x ↑ Eternal Poison_SLUS-21779_20241012094813 3x with with patch 3x ↑

In this I don't see any difference so I don't see any need to disable any routine.

NineKain commented 1 month ago

I guess the aliasing is a byproduct of making the game sharper, PCSX2 doesnt have any kind of AA apart from supersampling, native 480p games also have aliasing, I dont see it as a reason to not use deinterlacing patches

NineKain commented 1 month ago

gametitle=Tsugunai: Atonement NTSC-U SLUS-20292 * 9D57694E

Suggestion: Try out this hack to see if it works better.

[Widescreen 16:9] gsaspectratio=16:9 patch=1,EE,0017cf94,word,3c013f40 // field // patch=1,EE,0018c1ac,word,3c013f40 // ? patch=1,EE,001c1f30,word,3c013f40 // battle patch=1,EE,001b7e28,word,3c013f40 // amulet patch=1,EE,001acb94,word,3c013f40 // + patch=1,EE,001ac534,word,3c013f40 // + patch=1,EE,001c1ea4,word,3c013f40 // strage attack

works fine btw, dont notice much difference between this and og

NineKain commented 2 weeks ago

Can someone review this?