search

PCSX2 / pcsx2_patches

Patches for Widescreen, No Interlace etc go in here, syncs with the main repo
168 stars 75 forks source link

ICO - formating, additions and improvements #434

Closed pgert closed 1 week ago

PeterDelta commented 1 month ago

20:9 and 21:9 aspect ratios cause game crashes

Ico_SCES-50760_20241019124244 Ico_SCES-50760_20241019124233 4:3 original

Ico_SCES-50760_20241019124823 20 Ico_SCES-50760_20241019124732 20 20:9

Ico_SCES-50760_20241019122854 21 Ico_SCES-50760_20241019122809 21 21:9

I see that in some you put "description" and below "comment". Everything that is put in a comment is irrelevant and will not be seen in the pcsx2 patches section when there is a "description", in the absence of a description what is put in the comment will be seen. According to the changes of pnach 2.0, the new patches that are created change from comment to description, unless there is some plan that I am unaware of.

"comment" is the old format while "description" is the new format

pgert commented 1 month ago

Well crap. 20:9 & 21:9 removed.

DrAzathoth commented 1 month ago

For the debug menu patch, including info about how to change the framerate is redundant thanks to the 60 fps patch. The 60 fps patch already forces the debug framestep value to 1 (and 2 during cutscenes) so even if the user tried to change it, there would be no effect.

For the 21:9/20:9 patch, I tried it out and didn’t get a single crash. Is it reproducible?

pgert commented 1 month ago

For the debug menu patch, including info about how to change the framerate is redundant thanks to the 60 fps patch. The 60 fps patch already forces the debug framestep value to 1 (and 2 during cutscenes) so even if the user tried to change it, there would be no effect.

I have made it into a non-displaying comment instaed.

For the 21:9/20:9 patch, I tried it out and didn’t get a single crash. Is it reproducible?

@PeterDelta ?

PeterDelta commented 1 month ago

Reproducible? yes, but they are incomplete compared to the rest of the widescreen displays. This can be seen in the main menu itself.

DrAzathoth commented 1 month ago

Reproducible? yes, but they are incomplete compared to the rest of the widescreen displays. This can be seen in the main menu itself.

So, do you mean to say that there aren’t any crashes and only culling issues on the main menu and some cutscenes? I played through a vast chunk of the game and used the debug menu to skip to the end as well and encountered no crashes. Personally, I wouldn’t think culling would warrant an exclusion and aside from one or two cutscenes and the main menu (which are both extremely mild) I didn’t ever notice any culling issues.

@pgert, perhaps include the patch, but mention some mild culling beyond 16:9 during some scenes in the description?

pgert commented 4 weeks ago

There shouldn't be any problems with 16:10 & 15:10. The hacks for 20:9 & 21:9 are a bit different than for 16:10 & 15:10, and thats probably why there are imperfections.

crashGG commented 2 weeks ago

Hi, bro, could you port these patches to SCPS-55001_29C28734 (Asian) and SCCS-4005_BF3A46DA (China) of Ico? Thank you very much!

pgert commented 2 weeks ago

Hi, bro, could you port these patches to SCPS-55001_29C28734 (Asian) and SCCS-4005_BF3A46DA (China) of Ico? Thank you very much!

No, I can't. Try making a request at the forum: https://forums.pcsx2.net/Thread-PCSX2-Widescreen-Game-Patches