PCemOnMac / PCemV17macOS

Port of the PCem PC emulator for macOS. Comes with OpenGL 3.0 support built-in
GNU General Public License v3.0
68 stars 14 forks source link

Please update the default_roms_path to follow macOS Standards #29

Open d3vi1 opened 2 years ago

d3vi1 commented 2 years ago

Hi,

The default ROMS behavior should be changed. On the application startup, a folder ~/Library/Application Support/PCem should be created and the default roms,configs,nvr, etc. should be copied from $executable_path/../Resources/SKEL to that folder, so that the user can customize them without actually modifying the /Applications/PCem.app binary. If that initial provisioning is done, PCem shouldn't complain about ROMS at startup anymore. The expected path of ~/PCem or /usr/share/pcem is not documented in the error dialog box nor in stderr, nor is it created automatically.

Thanks, R.

almeath commented 2 years ago

Should this request be lodged in the bundler repository? (https://github.com/PCemOnMac/bundler)

The binary already looks for the "roms" folder (and all other config folders) under Application Support/PCem by default, as of this commit:

https://github.com/PCemOnMac/PCemV17macOS/commit/a06d30a42040c5844eebd622aeabdc9c03338fd7

There still has be be valid roms inside the roms folder in order to avoid the error message, and those cannot be included by default due to copyright. I just tested this now with a fresh build and it is working fine as long as valid roms go in the said folder.

If the problem is being separately caused by the behavior of the PCem application bundle, I will let @kyr0 know about it, as he has maintained the bundler going back to PCem v14.

almeath commented 2 years ago

I have mentioned in issue #28 that I am working on my own application bundle for PCem (separate to the one developed by @kyr0 ). If I can get issue #28 resolved, I can at least provide that bundle for download, which does create the config folders under Application Support/PCem.