search

PCextreme / cloudstack-php

Native PHP Cloudstack client
MIT License
10 stars 9 forks source link

Bump PHPUnit version from 5.x to 7.x #24

Closed FrontEndCoffee closed 5 years ago

FrontEndCoffee commented 6 years ago

We kept getting PHP_Warnings in our CI caused by an outdated version of phpunit/php-code-coverage.

This has been resolved by bumping the phpunit/phpunit version from 5.x to 7.x

One change that needed to be made: the PHPUnit_Testcase namespace. This has been updated in the codebase.

kevindierkx commented 6 years ago

This breaks compatibility with older laravel versions as mentioned in: https://github.com/PCextreme/cloudstack-php/pull/12

The whole test setup needs to be checked, there are some major differences between Scrutinizer and Travis atm.

FrontEndCoffee commented 6 years ago

@kevindierkx if this is a problem, maybe we should consider switching from composer-required to phar files (the implementation would be easy with a Makefile)

All of our testing tools are available in phar form

kevindierkx commented 5 years ago

In hindsight, as discussed in the office a new release would still cover older Laravel release since we've already tagged a release for those.

kevindierkx commented 5 years ago

Will adjust at a later time.