search

PDAL / java

Java extension and bindings for PDAL
https://pdal.io/java.html
Other
7 stars 9 forks source link

Update CI to support ARM build #76

Closed WhiteSte closed 8 months ago

WhiteSte commented 8 months ago

According to https://github.com/PDAL/java/issues/61#issuecomment-1892487183 I've tried to modify the CI in order to build the natives also for mac os arm64 architecture. The service flyci-macos-large-latest-m1 should be free on public repos for 500minutes/month, that should be quite enough as a temporary solution.

I'm not an expert of github actions, how can i test the pipeline if it works?

pomadchin commented 8 months ago

I'm not an expert of github actions, how can i test the pipeline if it works?

I think the best way to test is configuring and testing CI in your fork. Sadly there is not really good way to do it.

Thanks for making a PR!

WhiteSte commented 8 months ago

sounds like the new m1 runner is also building x86 arch and the old mac os one is building also arm arch . I will revise that

pomadchin commented 8 months ago

Interesting, these runners were not even allocated 🤔

WhiteSte commented 8 months ago

umh maybe @kgantchev can give us some clarifications

kgantchev commented 8 months ago

Thanks, I'll look over the thread in a bit and I'll get back to you with more info ASAP.

kgantchev commented 8 months ago

Interesting, these runners were not even allocated

BTW, what do you mean here?

WhiteSte commented 8 months ago

Interesting, these runners were not even allocated

BTW, what do you mean here?

the runners are not available

kgantchev commented 8 months ago

the runners are not available

Got it. We had an issue yesterday which we resolved. I'll check with our team to see if you might have been affected. My apologies if you experienced an interruption!

kgantchev commented 8 months ago

@WhiteSte we don't see an app installation for this GitHub account. Please make sure that you have installed the FlyCI GitHub app on the PDAL account.

@WhiteSte you can also fork the repo, install the FlyCI app, and run the actions in your account to validate that everything is working properly before making the contribution here (I assume the maintainers will be the happiest with that approach).