PDAL / java

Java extension and bindings for PDAL
https://pdal.io/java.html
Other
7 stars 9 forks source link

Apple binaries trusted signature #90

Closed pomadchin closed 6 months ago

pomadchin commented 6 months ago

We have ARM builds via https://github.com/PDAL/java/issues/61

However, it's not enough (see https://github.com/PDAL/java/pull/89#issuecomment-1997818375); we need to make the published dylib trusted so it seamlessly works.

We need to figure out how to sign binaries;

@metasim thanks for the help 🥇

Most likely we need https://github.com/Apple-Actions/import-codesign-certs

I found https://github.com/strawberrymusicplayer/strawberry/blob/master/.github/workflows/build.yml#L806-L809 and https://github.com/orgs/community/discussions/70145

More: https://github.com/PDAL/java/pull/89#issuecomment-1998059230

metasim commented 6 months ago

I wonder if self-signing (aka "adhoc") is better than nothing:

codesign --force -s - libpdaljni.2.6.dylib

From the manpage:

If identity is the single letter "-" (dash), ad-hoc signing is performed. Ad-hoc signing does not use an identity at all, and identifies exactly one instance of code. Significant restrictions apply to the use of ad-hoc signed code; consult documentation before using this.

pomadchin commented 6 months ago

@metasim lets try it!

pomadchin commented 6 months ago

Also https://localazy.com/blog/how-to-automatically-sign-macos-apps-using-github-actions

pomadchin commented 6 months ago

We don't need it, tested https://github.com/PDAL/java/pull/95 and https://github.com/PDAL/java/pull/96

All thx to @metasim 🔥