PDAL / java

Java extension and bindings for PDAL
https://pdal.io/java.html
Other
8 stars 10 forks source link

Added extra rpath entries to common macOS library install locations. #95

Closed metasim closed 8 months ago

metasim commented 8 months ago

@pomadchin Is it possible for you to publish a SNAPSHOT version so I can easily test the output from CI?

pomadchin commented 8 months ago

Sure, will merge it in once CI is happy

metasim commented 8 months ago

Sorry. I thought I had this working locally. Somehow, the @rpath substitution is now missing from libpdalcpp 😠

image
pomadchin commented 8 months ago

ha, what was the change to make it work?

metasim commented 8 months ago

ha, what was the change to make it work?

Basically reverting another change that I thought would eliminate an extra RC_RPATH record.

❯ otool -l  /Users/sfitch/Coding/OSS/PDAL-Java/native/target/native/arm64-darwin/bin/./libpdaljni.2.6.dylib | grep -A2 RPATH
          cmd LC_RPATH
      cmdsize 72
         path @rpath:/usr/local/lib:/opt/homebrew/lib:/opt/local/lib (offset 12)
--
          cmd LC_RPATH
      cmdsize 64
         path /opt/homebrew/Caskroom/miniconda/base/envs/pdal/lib (offset 12)

I thought I understood the setting behavior, but it was only passing locally because I relied on sbt clean rather than find . -name target -exec rm -r {} \;, as the former doesn't clean out all the cmake byproducts. See #91

pomadchin commented 8 months ago

Oh, the CMAKE_SKIP_BUILD_RPATH; cool; merging so you can try it out :+1:

metasim commented 8 months ago

How do I find the Maven Central coordinates?

pomadchin commented 8 months ago

sonatype snapshots! (https://oss.sonatype.org/content/repositories/snapshots/io/pdal/)

Check the readme, the orange button click!

image