PeterWone
commented
4 days ago I'll make it possible to select the renderer.
We're abandoning the built in renderer because Microsoft did things that made it impossible for us to support anything that depends on rendering script that runs in the browser ie Mermaid
It's less trouble than you think to support Kroki. It was already under consideration.
From: IfxBaderG @.> Sent: Wednesday, July 3, 2024 3:31:39 pm To: PDConSec/vsc-print @.> Cc: Subscribed @.***> Subject: [PDConSec/vsc-print] Revise the decision to change the rendering pipeline! (Issue #326)
With previous method to use the VS Code rendering pipeline plus Markdown Krokihttps://marketplace.visualstudio.com/items?itemName=pomdtr.markdown-kroki extension, you were able to render a ton of different diagrams directly in your markdown files. This functionality is now lost! Now you have to support everything on your own (e.g. #322https://github.com/PDConSec/vsc-print/issues/322 etc.).
I considered the method to use the VS Cide rendering pipeline a very smart design decision to reuse existing functionality an not having to implement again and again the support for new diagrams. When it is rendered in VS Code correctly ba any extension, then it were also able to print it with your extension.
So please, revise this decision or bring back the old method via configuration option.
— Reply to this email directly, view it on GitHubhttps://github.com/PDConSec/vsc-print/issues/326, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJ6QOFL5VOCTHCDERIY4QTZKOEDPAVCNFSM6AAAAABKI2CGDOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM4DONZQHAYDMNI. You are receiving this because you are subscribed to this thread.Message ID: @.***>
With previous method to use the VS Code rendering pipeline plus Markdown Kroki extension, you were able to render a ton of different diagram types directly in your markdown files. This functionality is now lost! Now you have to support everything on your own (e.g. https://github.com/PDConSec/vsc-print/issues/322 etc.).
I considered the method to use the VS Cide rendering pipeline a very smart design decision to reuse existing functionality and not having to implement again and again the support for new diagrams. When it is rendered in VS Code correctly ba any extension, then it were also able to print it with your extension.
@PeterWone So please, revise this decision or bring back the old method via configuration option.