search

PDDStudio / highlightjs-android

A view for source code syntax highlighting on Android
309 stars 50 forks source link

PHP file not parsed correct #2

Closed alorma closed 8 years ago

alorma commented 8 years ago

Hi.

I'm using this library in Gitskarios app, and i this file looks is not well parsed:

https://github.com/TextControl/txtextcontrol-reportingcloud-php/blob/master/src/Filter/DateTimeToTimestamp.php

I've checked, and after removing the <?php it loads all the content:

https://github.com/gitskarios/test_readme/blob/master/Test.php

GeorgeWL commented 8 years ago

I'd say this is a pretty key issue btw :+1:

PDDStudio commented 8 years ago

Thanks for reporting @alorma How are you loading the source into the view? (String, File or URL) Then I'll see whether I can reproduce this issue

alorma commented 8 years ago

It's from a String

alorma commented 8 years ago

https://github.com/gitskarios/Gitskarios/blob/develop/app/src/main/java/com/alorma/github/ui/fragment/FileFragment.java#L117

PDDStudio commented 8 years ago

Alright, and the language is set to AUTO_DETECT ?

alorma commented 8 years ago

Yes, you can see in the same file

PDDStudio commented 8 years ago

Same here. See #3 for details.

PDDStudio commented 8 years ago

Should be fixed with Version 1.2.0