PDHdata / SmallFormats

Deck-stats server for less-common Magic: the Gathering formats
MIT License
6 stars 0 forks source link

We want something like a synergy score #45

Closed vtbassmatt closed 1 year ago

vtbassmatt commented 1 year ago

EDHrec calculates a card's synergy with respect to a commander as:

(% decks this card is in for commander/theme) - (% decks this card is in for color identity)

I haven't convinced myself that this is the score I want to use. Subtracting percentages with different bases doesn't seem mathematically sound. Consider the following universe of decks:

This is hard to reason about. Shiny Knight and Fast Bird are, in a meaningful sense, bound equally tightly to their relevant commander (appearing in 100% of that commander's decks and nowhere else). But their synergy scores differ dramatically because of the larger variety in Bird Guy decks.

aormiston commented 1 year ago

One way to simplify the interpretation of this could be to remove the commander in question's decks from the comparison percentage.

For Brave Knight, it would look like: 50/50 Brave Knight 0/150 Other Mono White (Non Brave Knight) 100% - 0% = 100% synergy

For Bird Guy it would look like: 100/100 Bird Guy 0/100 Other Mono White 100% - 0% = 100% synergy

This at least makes the interpretation for both consistent, despite having different total decks considered.

It also works for something like Sol Ring

Sol Ring 50/50 Brave Knight 150/150 Other Mono White 100%-100% = 0% Synergy

What do you think?

vtbassmatt commented 1 year ago

I think you’re on to something here. Thank you! When I get a little spare time, I’ll see if this is straightforward to calculate from the existing tables or if there’s a bit more number crunching to do.

aormiston commented 1 year ago

Could be cool to do the same thing by subsetting to only decks that could have used the card as of the most recent "updated at" timestamp on the deck.

In other words, "how many decks that have been updated since this card was printed have chosen to use it?"

Might help to avoid skewing a synergy score down due to a large number of stale decks.

vtbassmatt commented 1 year ago

This will be available soon. (The feature is dark-shipped and currently filing out initial scores.)