When get-decklists started failing, no indication in logs

PDHdata / SmallFormats

Deck-stats server for less-common Magic: the Gathering formats

MIT License

6 stars 0 forks source link

When get-decklists started failing, no indication in logs #88

Open vtbassmatt opened 5 months ago

vtbassmatt commented 5 months ago

get-decklists started failing at some point due to a None where it expected an empty list. This meant the logs just trailed off, no indication they hadn't completed, so it went unnoticed for a while.

Some options:

update-site-stats could shout if there are unprocessed runs/decks/etc
Put try/catches in all the right spots to recover and raise an error to the logs
Build some additional tool which checks for coherence

vtbassmatt commented 5 months ago

(The specific get-decklists bug is fixed in https://github.com/PDHdata/SmallFormats/pull/87/commits/36646a002922e507892671ef56555535cba5f367 but who knows where else it might blow up in the future.)