PDHung1104 / pe

0 stars 0 forks source link

Wrong output when payer and payees are the same #3

Open PDHung1104 opened 2 months ago

PDHung1104 commented 2 months ago

image.png

With this input, it is not an equal share. I suggest checking if the payee is the same as the payer. If yes, do not increase the number of payees.

soc-pe-bot commented 2 months ago

Team's Response

Accepted as a missing error handling when the same member is added as both payer and payee as the product should throw an error message when the user inputs the same name as payer and payee.

However, the severity should be low and not high because this issue is due to a missing error handling. Hence, it will not affect normal operations of the product or cause major problems for users. And it will not make the product almost unusable for most users.

image.png

This bug is a duplicate of #1422 where the payer and payee names are the same which results in a missing error handling.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Multiple same member in expense command

image.png Accidentally put in my friend "adarsh s" multiple times in the groupname but no error handling occurred image.png


[original: nus-cs2113-AY2324S2/pe-interim#1689] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Accepted as a missing error handling when the same member is added as both payer and payee as the product should throw an error message when the user inputs the same name as payer and payee.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]