PDHung1104 / pe

0 stars 0 forks source link

Wrong payer name for `list` command #4

Open PDHung1104 opened 2 months ago

PDHung1104 commented 2 months ago

I added member called Linh### into group bcd which I created earlier. After added an expense and exit the program as follows, I opened the program again.

image.png

I used list to check for expenses, but the following is displayed.

image.png

nus-se-script commented 2 months ago

Team's Response

The bug is caused by the username: Linh###. There is a # in the username string that is used as a delimiter for our database. Therefore, upon exit and reentry of program, the payerName parameter in the Expense class was not initialised correctly which caused an incorrect payer name to be displayed upon entering the list command.

image.png

This error is not high as it is only produced when fields entered contain # in them. Most users are unlikely to enter these characters on a general basis. As such, we think that the severity should be medium because this is a flaw that causes occasional inconvenience to some users that use the # in a username. Furthermore, they can continue to use the product because their data is still saved, and they can still use other features. Hence, this will not make the product unusable for most users.

This is a duplicate of #87 as user entered # in their username.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

application crashes upon use of balance command for decription with #s in expenses

make sure alice and bob are members of the group expense list used

image.png

command to add expense: expense stuff#8 /amount 9.00 /paid alice /user bob

upon exiting and entering the application, enter the group with the added expense and type balance alice

image.png


[original: nus-cs2113-AY2324S2/pe-interim#75] [original labels: type.FunctionalityBug severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The bug is caused by the expense command: expense stuff#8 /amount 9.00 /paid alice /user bob. There is a # in the expense description that is used as a delimiter for our database. Therefore, upon exit and reentry of program, the moneyList parameter in the Group class was not initialised which caused an illegal access error when entering the balance alice command again.

image.png

This error is not high as it is only produced when fields entered contain # in them. Most users are unlikely to enter these characters on a general basis. As such, we think that the severity should be medium because this is a flaw that causes occasional inconvenience to some users that use the # in the description, payee_name and payer_name. Furthermore, they can continue to use the product because their data is still saved, and they can still use other features. Hence, this will not make the product unusable for most users.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.High`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]