add multiplot layout options: scale, offset, margins, spacing ; deprecate old style of speciyfing them

PDLPorters / PDL-Graphics-Gnuplot

Gnuplot-based plotting backend for PDL

https://p3rl.org/PDL::Graphics::Gnuplot

Other

8 stars 7 forks source link

add multiplot layout options: scale, offset, margins, spacing ; deprecate old style of speciyfing them #102

Open djerius opened 1 year ago

djerius commented 1 year ago

add multiplot layout options: scale, offset, margins, spacing ; deprecate old style of speciyfing them.

previously scale & offset were provided as separate multiplot options, which were rendered as plain numbers independent of the layout option. gnuplot 5.4 doesn't recognize that syntax. they must be part of the layout option.

Now, they are specified inline in the arrayref passed to the layout option.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 6694895348

0 of 0 changed or added relevant lines in 0 files are covered.
342 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 58.974%

Files with Coverage Reduction	New Missed Lines	%
/home/runner/work/PDL-Graphics-Gnuplot/PDL-Graphics-Gnuplot/blib/lib/PDL/Graphics/Gnuplot.pm	342	58.97%
<!--	Total:	342		-->

Totals
Change from base Build 6059458690:	0.0%
Covered Lines:	828
Relevant Lines:	1404

💛 - Coveralls

djerius commented 8 months ago

Hola out there! Any problem if I merge these?

mohawk2 commented 7 months ago

Yes. Do not go merging things please.

Where are the tests of this changed functionality?

mohawk2 commented 7 months ago

Hi @djerius, are you going to add tests for this stuff?

djerius commented 6 months ago

I'll get to tests shortly I hope.