PDLPorters / PDL-Graphics-Prima

A graphing widget using the Prima toolkit
13 stars 6 forks source link

greatly simplify event loop management #44

Closed dk closed 1 year ago

dk commented 1 year ago

breaks current PDL::Graphic::Simple though -- will make a separate PR

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3928758870


Files with Coverage Reduction New Missed Lines %
/home/runner/work/PDL-Graphics-Prima/PDL-Graphics-Prima/blib/lib/PDL/Graphics/Prima/Simple.pm 12 9.48%
<!-- Total: 12 -->
Totals Coverage Status
Change from base Build 3923179860: 0.03%
Covered Lines: 853
Relevant Lines: 2412

💛 - Coveralls
mohawk2 commented 1 year ago

Please could you resolve the conflict that now shows? Also, what version of Prima does this require?

dk commented 1 year ago

done

mohawk2 commented 1 year ago

Thank you! Could you also rebase it against current master and force-push, rather than a merge commit? (That would also be an opportunity to squash in the "removed too much, restore" change :-) My best-case scenario is each commit is a small, meaningful change towards the end-goal of the PR.

dk commented 1 year ago

I'd love to learn how to do that because I have no idea, and am generally afraid of rebasing -- sorry :)

mohawk2 commented 1 year ago

I did a squash-merge as discussed elsewhere, to keep the history looking understandable.