PDLPorters / PDL-Graphics-Simple

This is an interface layer to the several PDL::Graphics modules out there. It is intended to become part of the PDL core.
https://p3rl.org/PDL::Graphics::Simple
5 stars 4 forks source link

Support 'windows' terminal type. #2

Closed aero closed 3 years ago

aero commented 10 years ago

HI, In Strawberry Perl 5.20 PDL edition http://strawberryperl.com/download/5.20.0.1/strawberry-perl-5.20.0.1-32bit-PDL.zip http://strawberryperl.com/download/5.20.0.1/strawberry-perl-5.20.0.1-64bit-PDL.zip

@kmx ( https://github.com/kmx ) puts his own compiled gnuplot 4.6.5 binary in that files. It only supports 'windows' terminal type. (it seems that it is different from the official gnuplot distribution http://sourceforge.net/projects/gnuplot/files/gnuplot/4.6.5/ which support 'wxt' terminal type.)

but PDL::Graphics::Simple supports 'x11' and 'wxt'.

Can PDL::Graphics::Simple support 'windows' terminal type?

sisyphus commented 10 years ago

From: aero Sent: Saturday, July 05, 2014 11:06 AM

Can PDL::Graphics::Simple support 'windows' terminal type?

Hi aero,

I don't know the answer to the question - but I have 2 observations:

1) There's nothing to stop you using the "official gnuplot distribution". (You probably already know that :-)

2) If it turns out that the version that kmx has provided is deficient in some way, please let him know - for future reference.

Cheers, Rob

drzowie commented 10 years ago

It doesn't currently support "windows" terminal type -- but it's an easy fix to fail over to it. I'll put it on the to-do list.

On Jul 4, 2014, at 7:06 PM, aero notifications@github.com wrote:

HI, In Strawberry Perl 5.20 PDL edition http://strawberryperl.com/download/5.20.0.1/strawberry-perl-5.20.0.1-32bit-PDL.zip http://strawberryperl.com/download/5.20.0.1/strawberry-perl-5.20.0.1-64bit-PDL.zip

@kmx ( https://github.com/kmx ) puts his own compiled gnuplot 4.6.5 binary in that files. It only supports 'windows' terminal type. (it seems that it is different from the official gnuplot distribution http://sourceforge.net/projects/gnuplot/files/gnuplot/4.6.5/ which support 'wxt' terminal type.)

but PDL::Graphics::Simple supports 'x11' and 'wxt'.

Can PDL::Graphics::Simple support 'windows' terminal type?

— Reply to this email directly or view it on GitHub.

drzowie commented 10 years ago

OK, I've pushed up a patch that supports the windows type. See if that works for you on your platform.

Cheers, Craig

On Jul 5, 2014, at 5:17 AM, sisyphus notifications@github.com wrote:

From: aero Sent: Saturday, July 05, 2014 11:06 AM

Can PDL::Graphics::Simple support 'windows' terminal type?

Hi aero,

I don't know the answer to the question - but I have 2 observations:

1) There's nothing to stop you using the "official gnuplot distribution". (You probably already know that :-)

2) If it turns out that the version that kmx has provided is deficient in some way, please let him know - for future reference.

Cheers, Rob — Reply to this email directly or view it on GitHub.

aero commented 10 years ago

Hi, I tried. but I got the following error message.

>perl -Mblib t\simple.t
1..85
ok 1
NAME       Module                         (synopsis)
----       ------                         ----------
gnuplot    PDL::Graphics::Gnuplot         Gnuplot 2D/3D (versatile; beautiful output)
pgplot     PDL::Graphics::PGPLOT::Window  PGPLOT (venerable but trusted)
plplot     PDL::Graphics::PLplot          PLplot (nice plotting, sloooow images)
prima      PDL::Graphics::Prima           Prima (interactive, fast, PDL-specific)

ok 2
ok 3 - module registration hash exists
ok 4 - there is a modules entry for gnuplot (PDL::Graphics::Simple::Gnuplot)
ok 5 - PDL::Graphics::Simple::Gnuplot::check() ran OK
ok 6 - contructor for gnuplot worked OK
not ok 7 - plot succeeded
#
#   Failed test 'plot succeeded
# '
#   at t\simple.t line 68.
Can't call method "plot" on unblessed reference at D:\Downloads\PDL-Graphics-Simple-master\PDL-Graphics-Simple-master\blib\lib/PDL/Graphics/Simple.pm line 1032, <FOO> line 164.

Testing gnuplot engine: You should see a superposed line plot and bin
plot, with x range from 0 to 9 and yrange from 0 to 9. The two plots
should have different line styles.  OK? (Y/n) >
drzowie commented 10 years ago

Hmmm...

OK, it appears that the "windows" terminal doesn't support the "persist" option. I went ahead and added a switch to support terminals without that option (windows and aero). Give that a whirl. It may fail the interactive test "window disappeared". If so, I'd appreciate any input you may have on how to destroy a 'windows' terminal display window.

Cheers, Craig

On Jul 5, 2014, at 10:12 AM, aero notifications@github.com wrote:

Hi, I tried. but I got the following error message.

perl -Mblib t\simple.t 1..85 ok 1 NAME Module (synopsis)


gnuplot PDL::Graphics::Gnuplot Gnuplot 2D/3D (versatile; beautiful output) pgplot PDL::Graphics::PGPLOT::Window PGPLOT (venerable but trusted) plplot PDL::Graphics::PLplot PLplot (nice plotting, sloooow images) prima PDL::Graphics::Prima Prima (interactive, fast, PDL-specific)

ok 2 ok 3 - module registration hash exists ok 4 - there is a modules entry for gnuplot (PDL::Graphics::Simple::Gnuplot) ok 5 - PDL::Graphics::Simple::Gnuplot::check() ran OK ok 6 - contructor for gnuplot worked OK not ok 7 - plot succeeded #

Failed test 'plot succeeded

'

at t\simple.t line 68.

Can't call method "plot" on unblessed reference at D:\Downloads\PDL-Graphics-Simple-master\PDL-Graphics-Simple-master\blib\lib/PDL/Graphics/Simple.pm line 1032, line 164.

Testing gnuplot engine: You should see a superposed line plot and bin plot, with x range from 0 to 9 and yrange from 0 to 9. The two plots should have different line styles. OK? (Y/n) > — Reply to this email directly or view it on GitHub.

aero commented 10 years ago

Hi, I tried again. I still got the same error message. There are no gnuplot pop-up window and "windows disappreared" error.

drzowie commented 10 years ago

Hmmm...

Could you try this?

perldl> use PDL::Graphics::Gnuplot; perldl> $w=gpwin(windows,size=>[5,5],title=>"foo",font=>"=16");

If that succeeds, great! If it fails, please let me know the error message.

Cheers, Craig

On Jul 5, 2014, at 10:47 AM, aero notifications@github.com wrote:

Hi, I tried again. I still got the same error message. There are no gnuplot pop-up window and "windows disappreared" error.

— Reply to this email directly or view it on GitHub.

kmx commented 10 years ago

Could you try this?

perldl> use PDL::Graphics::Gnuplot; perldl> $w=gpwin(windows,size=>[5,5],title=>"foo",font=>"=16");

pdl> $w=gpwin(windows,size=>[5,5],title=>"foo",font=>"=16"); Compile error: Bareword "windows" not allowed while "strict subs" in use at (eval 410) line 5, line 164.

However this sequence works nice:

pdl> use PDL::Graphics::Gnuplot pdl> $w=gpwin("windows",size=>[5,5],title=>"foo",font=>"=16") pdl> $x = sequence(101) - 50 pdl> $w->plot($x**2)

--kmx

mohawk2 commented 3 years ago

I'm going to close this on the assumption that the above (and patches on master by Craig) fixed this. I will be releasing an updated version to CPAN shortly (as soon as I've fixed https://rt.cpan.org/Ticket/Display.html?id=86275), and will ask you to try that and report issues!