update to breaking change in PDL::Graphics::Prima

dk commented 1 year ago

see https://github.com/PDLPorters/PDL-Graphics-Prima/pull/44

mohawk2 commented 1 year ago

Could you make the check function ensure it has the right version of P:G:Prima rather than just assume?

dk commented 1 year ago

now it requires the non-yet-released v0.18

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3928790955

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.576%

Totals
Change from base Build 3804023024:	0.0%
Covered Lines:	390
Relevant Lines:	1011

💛 - Coveralls

mohawk2 commented 1 year ago

@dk Thanks, this and P:G:Prima will be getting released very soon!

There is one gremlin, in the P:G:Prima demo. Install latest Prima and P:D:Prima, and be in master of P:G:Prima (uninstall it if you have it installed, for easier hacking). The latest master has a minor hack needed for the scoping rules of the current PDL::Demos system, changing a my to an our.

$ perl -Ilib -S perldl # runs the perldl shell, lets it see P:G:Prima
perldl> demo prima # click through till you get to the "Adding a title and axis labels" section
---- Code:
  # starting up the Prima GUI demo app
  PDL::Demos::Prima::run();
---- Output:
Illegal object reference passed to Component.notify at lib/PDL/Graphics/Prima.pm line 463.
 at lib/PDL/Graphics/Prima.pm line 463.
    Prima::Plot::title(Prima::Plot=HASH(0x5568e08f6d88), "Harmonic Oscillator") called at (eval 437) line 1
    eval 'no strict; no warnings; $plot->title(\'Harmonic Oscillator\');

Can you help?

dk commented 1 year ago

Sure thing - I addressed this just now in #48

dk commented 1 year ago

https://github.com/PDLPorters/PDL-Graphics-Prima/pull/48

mohawk2 commented 1 year ago

Thank you!

PDLPorters / PDL-Graphics-Simple