search

PDP-10 / its

Incompatible Timesharing System
Other
834 stars 80 forks source link

Greatly simplified the code in MLDEV. #2237

Closed eswenson1 closed 8 months ago

eswenson1 commented 9 months ago

See #2232 for previous version comments that led to this version.

eswenson1 commented 9 months ago

I updated this branch with review comments from @bictorv. Thanks for them. Please take a look of this updated version. Also, @larsbrinkhoff please review as well.

eswenson1 commented 9 months ago

You didn't want BUBUNV 78 in this pull request, right? :-)

What is BUBUNV?

eswenson1 commented 9 months ago

You didn't want BUBUNV 78 in this pull request, right? :-)

What is BUBUNV?

I guess it is Lars’ bubble universe. And why would that make sense as a part of this PR?

larsbrinkhoff commented 9 months ago

Looks pretty good to me, but I will defer to Björn.

I don't know how the BUBUNV commit got in there. There's a suspicious merge commit that shouldn't happen if you just rebased. Maybe you merged first, then rebased?

eswenson1 commented 8 months ago

@larsbrinkhoff this PR is still open pending your review. Also, how can I fix the BUBUNV inclusion?

larsbrinkhoff commented 8 months ago

I'm mostly deferring to @bictorv.

I can do a rebase and probably fix the branch. Is it ok for me to force push?

bictorv commented 8 months ago

I'm mostly deferring to @bictorv.

I gave OK, modulo the BUBUNV and the thing Eric fixed.

eswenson1 commented 8 months ago

@larsbrinkhoff please do fix the BUBUNV inclusion (and rebase). Thanks.

eswenson1 commented 8 months ago

@bictorv Please approve this PR (or provide other issues I need to resolve).

larsbrinkhoff commented 8 months ago

One approval is sufficient for allowing merging.

eswenson1 commented 8 months ago

Yes, but we agreed that I’d wait until Björn and you approved this one.