search

PDP-10 / its

Incompatible Timesharing System
Other
834 stars 80 forks source link

Updated Zork to address issue with bad message when opening non-functional windows #2257

Closed eswenson1 closed 7 months ago

eswenson1 commented 7 months ago

When you attempt to "open window" in the North and South of House, you get a response that isn't appropriate. With this fix, you get "This window cannot be opened.".

Addresses this issue: https://github.com/heasm66/mdlzork/issues/58 And this fix: https://github.com/heasm66/mdlzork/pull/59

https://github.com/AlexProudfoot

larsbrinkhoff commented 7 months ago

The builds all fail like this. Maybe insert a <QUIT> after ACT1 and start a fresh compiler for ACT2?

<FILE-COMPILE "act2 >">$
Input from DSK:LCF;ACT2 92
Output to DSK:LCF;ACT2 NBIN
Bounds checking on.
Default declaration is UNSPECIAL.
Output in fast mode.
Temporary output going to:  _ACT1 >
Running disowned, with record on DSK:LCF;ACT2 RECORD
Toodle-oo.
:PROCED
*
$p
:$ FATAL ERROR ILLEGAL UUO $
*
eswenson1 commented 7 months ago

The builds all fail like this. Maybe insert a <QUIT> after ACT1 and start a fresh compiler for ACT2?

Yes. Sure nice to see in the build log why it failed! And yes, that will probably fix it. I don’t have this issue on ES. I wonder why?

eswenson1 commented 7 months ago

@larsbrinkhoff Can you approve? Looks like builds are happy with my new approach. @heasm66 I think I added you as a reviewer as well.

larsbrinkhoff commented 7 months ago

Great, finally! It's strange that XXFILE (or something else) worked ok but not any more.

I'll just split the commit in twain: one for Zork updates, and one for Tcl changes.

larsbrinkhoff commented 7 months ago

Three actually; the single commit has been split, but the end result is identical. Approved.

A question: should the XXFILEs still be there as a convenience for building Zork manually?

eswenson1 commented 7 months ago

A question: should the XXFILEs still be there as a convenience for building Zork manually?

I think so. I use them to build on ITS. Too cumbersome to be done manually.

eswenson1 commented 7 months ago

Great, finally! It's strange that XXFILE (or something else) worked ok but not any more.

Yeah. The XXFILE approach works fine for me on ES and EX, as long as I’m not running them from expect. No clue why that is the case. Actually sometimes it runs under expect too — but not always.