search

PDP-10 / its

Incompatible Timesharing System
Other
834 stars 80 forks source link

Update README.md #2273

Closed jordanhubbard closed 4 months ago

jordanhubbard commented 4 months ago

install_macosx function has been renamed to install_osx

eswenson1 commented 4 months ago

Why the rename to install_osx? OS/X is an old/obsolete name for the Mac operating system. The correct name for the OS is now macOS (spelled that way).

I’d recommend “install_macOS”.

jordanhubbard commented 4 months ago

Because that is the name of the function in the shell script - I assumed someone changed the name in the script without changing the documentation. As long as both are in sync, it’s fine.

On Feb 19, 2024, at 22:28, Eric Swenson @.***> wrote:

Why the rename to install_osx? OS/X is an old/obsolete name for the Mac operating system. The correct name for the OS is now macOS (spelled that way).

I’d recommend “install_macOS”.

— Reply to this email directly, view it on GitHub https://github.com/PDP-10/its/pull/2273#issuecomment-1953563595, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGU4DCMYMWB3Q7V4OP45DTYUQ67TAVCNFSM6AAAAABDQQRU5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTGU3DGNJZGU. You are receiving this because you authored the thread.

ams commented 4 months ago

I’d recommend “install_macOS”.

Lower case please... since this is something a user is going to type.

jordanhubbard commented 4 months ago

I didn’t mean to start a naming war, particularly since I’m a little too close to macOS to be opinionated about it, I am merely trying to align README.md and build/dependencies.sh since they are currently out of sync.

FWIW, the official Apple brand is “macOS” - capital O, capital S. As one of the creators of macOS, however, I don’t want to dictate how others choose to spell it.

On Feb 19, 2024, at 22:38, Alfred M. Szmidt @.***> wrote:

I’d recommend “install_macOS”.

Lower case please... since this is something a user is going to type.

— Reply to this email directly, view it on GitHub https://github.com/PDP-10/its/pull/2273#issuecomment-1953572841, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGU4DFBYNMTAOIGWGH7I63YURAGBAVCNFSM6AAAAABDQQRU5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTGU3TEOBUGE. You are receiving this because you authored the thread.

jordanhubbard commented 4 months ago

FWIW, if we're "voting" on this, I would suggest a single change to name it macOS in both places. If everyone can align on that, I'll submit two updated PRs that commits just the renaming change.

ams commented 4 months ago

Typing capital letters for one system is annoying though. Should it now be Linux instead of linux?

Sorry for closing, pressed the wrong button. :-(

larsbrinkhoff commented 4 months ago

This wasn't really meant to be a user facing name. dependencies.sh was just a helper for the continuous integration scripts. But now the cat's out of the bag, and maybe that's just as well.

The name is part of an identifier, which ends up being called inside a shell script. Stylistically, I think lower case works better. Maybe this design is questionable, and the script could just as well take a name as an argument, and act accordingly. In that case it could even be case insensitive. If someone wants to do a minor rewrite of the script, give it a go.