search

PDP-10 / its

Incompatible Timesharing System
Other
834 stars 80 forks source link

Update deploy-ftp.sh #2294

Closed oilcan-productions closed 3 months ago

oilcan-productions commented 3 months ago

Adding validation function to the deploy_ftp.sh script to ensure the upload was successful. If the upload was not successful, the script will exit with status code 1 and fail the build

larsbrinkhoff commented 3 months ago

Do you think the FTP password will keep expiring in the future?

larsbrinkhoff commented 3 months ago

The next to last line of the "Deploy" section says "find: ‘../pdp10-ka’: No such file or directory". Is that something to fix?

https://github.com/PDP-10/its/actions/runs/8441743024/job/23139306028

Testing download of pdp10-ka.tgz
[...]
Testing archive pdp10-ka.tgz
Unpacking successful!
Testing archive integrity
find: ‘../pdp10-ka’: No such file or directory
The contents of ../pdp10-ka and ./pdp10-ka are binary identical.
oilcan-productions commented 3 months ago

No, I do not expect it to expire again. I also set up a test loop here to ensure that FTP in general keeps working.

oilcan-productions commented 3 months ago

The next to last line of the "Deploy" section says "find: ‘../pdp10-ka’: No such file or directory". Is that something to fix?

https://github.com/PDP-10/its/actions/runs/8441743024/job/23139306028

Testing download of pdp10-ka.tgz
[...]
Testing archive pdp10-ka.tgz
Unpacking successful!
Testing archive integrity
find: ‘../pdp10-ka’: No such file or directory
The contents of ../pdp10-ka and ./pdp10-ka are binary identical.

Let me look into that, have not seen that locally.

oilcan-productions commented 3 months ago

Looking into the job log I think that at the end of the build we did not drop back to the its directory, which is the assumption I am making right now in the script.

larsbrinkhoff commented 2 months ago

@oilcan-productions, I often get this now. If I rerun the build 1-2 times it will usually work. Any idea why? Screenshot from 2024-04-12 07-02-06

oilcan-productions commented 2 months ago

Strange, this is the error somebody else was getting as well before. Could it be that multiple builds are running at the same time and uploading the same file concurrently?

Mike

[horizontal bar] Mike Kostersitz Oilcan Productions LLC, Owner [cid:1d3cc56e-790c-4a6f-8b9a-329552e43360] +1 (425) 324 4130 629 Emory Dr Snohomish, WA 98290 https://www.oilcan.mobihttps://www.oilcan.mobi/

From: Lars Brinkhoff @.> Sent: 11 April 2024 22:03 To: PDP-10/its @.> Cc: Mike Kostersitz @.>; Mention @.> Subject: Re: [PDP-10/its] Update deploy-ftp.sh (PR #2294)

@oilcan-productionshttps://github.com/oilcan-productions, I often get this now. If I rerun the build 1-2 times it will usually work. Any idea why? Screenshot.from.2024-04-12.07-02-06.png (view on web)https://github.com/PDP-10/its/assets/775050/7480a815-23bc-4c27-84ed-38b40e0f0154

— Reply to this email directly, view it on GitHubhttps://github.com/PDP-10/its/pull/2294#issuecomment-2050980976, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASO6P5ORK3XUMIRJHHPTDZTY45TKPAVCNFSM6AAAAABFJGNOCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJQHE4DAOJXGY. You are receiving this because you were mentioned.Message ID: @.***>

larsbrinkhoff commented 2 months ago

All variant builds run in parallel, but they upload different file names. Also, rerunning a single failed job by itself has resulted in a broken file so I don't think parallelism is the cause. Next time I'll try to manually download the file to check the contents.

larsbrinkhoff commented 2 months ago

Three out of six jobs failed. Screenshot from 2024-04-17 07-09-48