search

PDP-10 / its

Incompatible Timesharing System
Other
857 stars 81 forks source link

Let COMSAT recompile .MAIL.;NAMES when HOSTS3 has been updated #2337

Closed bictorv closed 3 weeks ago

bictorv commented 1 month ago

NAMES is normally recompiled to a binary "EQV file" when either there was no such file, or NAMES has been updated later than the creation date of the EQV file.

However, the compilation translates host names in NAMES to binary host addresses in the EQV file, so if the address of some host name has changed since compilation, the new addresses won't be used.

This PR checks for this case: when NAMES would not normally need recompilation, check if SYSBIN;HOSTS3 has been updated since the last NAMES compilation and if so, recompile to get any fresh host addresses.

All changed code is under a $$H3CHK switch.

Closes #2330.

eswenson1 commented 4 weeks ago

Did you intend to assign to me or to have me be a reviewer? If you did intend to assign to me (and Lars) just what are you expecting us to do?

larsbrinkhoff commented 4 weeks ago

Looks like @bictorv assigned us by mistake, and then assigned himself.

@eswenson1, you shouldn't approve this if you want file versions to be bumped.

bictorv commented 4 weeks ago

Please bump FN2.

Lars did already do that? But only once for the two PRs.

eswenson1 commented 4 weeks ago

Right. It looks like this PR doesn’t have FN2 bumped — unless he merged this PR’s changed into the other PR. I can’t tell.

bictorv commented 4 weeks ago

You can tell from the FN2 of the changed file. :-)

larsbrinkhoff commented 3 weeks ago

Yes, version was bumped in the very previous pull request. Merged now.