PDP-10 / klh10

Community maintained version of Kenneth L. Harrenstien's PDP-10 emulator.
Other
59 stars 7 forks source link

Add missing fclose after tape format detection. #34

Closed atsampson closed 5 years ago

atsampson commented 6 years ago

Without this, doing something like:

devmount mta0 /tmp/foo
devunmount mta0

(i.e. without specifying fmt=bar to the devmount) will leak a FILE * and file descriptor. It looks like df isn't used after this point in the function, aside from the error cleanup code at the bottom...

larsbrinkhoff commented 5 years ago

Ping @atsampson and @Rhialto. This pull request seems stuck in limbo. Can we push it forward somehow?

Rhialto commented 5 years ago

I suppose I could merge as-is, and then do the changes I was thinking about myself.