PDP-10 / klh10

Community maintained version of Kenneth L. Harrenstien's PDP-10 emulator.
Other
59 stars 7 forks source link

Stop CH11 from spontaneously retransmitting last pkt #48

Closed bictorv closed 3 years ago

bictorv commented 3 years ago

by noting that the output buffer was consumed on transmission done.

This is a bug which has been irritating me for about 14 years.

Rhialto commented 3 years ago

I suppose it looks good to me. I'm not sure why the Cirrus CI fails. It doesn't look like it has anything to do with this change.

larsbrinkhoff commented 3 years ago

Looks like a temporary error accessing FreeBSD packages. I'm rerunning the Cirrus build.

Rhialto commented 3 years ago

@larsbrinkhoff Looks like it still fails in the same way? I won't let that stop merging this. Unless you think there is something wrong with it...

larsbrinkhoff commented 3 years ago

I now remember I had this problem with ITS as well. The solution was to upgrade from FreeBSD 12.0 to 12.1. (See https://github.com/PDP-10/its/pull/1865) I'm submitting a pull request for this.

larsbrinkhoff commented 3 years ago

That did the trick. I'd say go ahead and merge this one, or #49 in either order.