search

PDP-10 / klh10

Community maintained version of Kenneth L. Harrenstien's PDP-10 emulator.
Other
59 stars 7 forks source link

IMP: Use reasonable interface methods #61

Closed bictorv closed 2 years ago

bictorv commented 2 years ago

and also check for consistency. And fix a cut-and-paste error.

NOTE that this makes the default ITS build use pcap (which makes sense since the gwaddr parameter is given there) rather than the current tun method. I don't know what was really the intention there (I always use tun on my ITSes). @larsbrinkhoff might have something to say?

Rhialto commented 2 years ago

It's fine with me, but I'll wait a day or so to see if @larsbrinkhoff has a different opinion.

larsbrinkhoff commented 2 years ago

The change looks ok to me, but I'll pass on the baton to @eswenson1.

Maybe the ITS configuration should be updated.

bictorv commented 2 years ago

Maybe the ITS configuration should be updated.

I would suggest that tun be the default. This would lower the risk that anyone exposes an ITS directly to the Big Bad Internet.