PDP-10 / klh10

Community maintained version of Kenneth L. Harrenstien's PDP-10 emulator.
Other
59 stars 7 forks source link

read20 should print author information #66

Open ams opened 1 year ago

ams commented 1 year ago

TOPS-20 tapes store author information, read20 should print it.

For dump.h add:

#define WdoffAuthor      WdoffFDB+030   /* Author offset */

Then in doFileHeader:

    getstring(block, authorname, WdoffAuthor, sizeof(authorname), STRING);

and print it when in verbose mode:

printf("%5d%9d %2d %o %s %s %s", offline ? apgcount : pgcount,
                   numbytes, bytesize, tprot, timeptr, topsname, authorname);
Rhialto commented 1 year ago

Sounds like a good idea! When I try to compile read20, I notice lots of compiler warnings. I'll clean it up first, and then get to your change.

ams commented 1 year ago

Hm, is there any reason to clean up? Wouldn't it be better to sync this version of read20 with the one in https://github.com/brouhaha/tapeutils ?

Rhialto commented 1 year ago

I wasn't aware of that version It seems the version have diverged. Maybe it is smarter to ask brouhaha to incorporate any improvements that KLH made to this version.

larsbrinkhoff commented 1 year ago

@brouhaha has mostly left the maintenance of https://github.com/brouhaha/tapeutils/ to me. Yes, I agree that merging all diverging versions to the brouhaha upstream would be good.