Rename `fatal` function ⟶ `fatalmsg` in supdupd

PDP-10 / supdup

Community maintained SUPDUP client for Unix

Other

16 stars 8 forks source link

Rename `fatal` function ⟶ `fatalmsg` in supdupd #29

Closed johnsonjh closed 3 years ago

johnsonjh commented 3 years ago

supdup: Hide global debug symbol.
supdupd: Rename fatal function ⟶ fatalmsg.

Provocatively avoid possible symbol conflicts.

larsbrinkhoff commented 3 years ago

What's the problem with using fatal?

johnsonjh commented 3 years ago

OpenSSH/libssh contains fatal() so renaming here avoids the symbol conflict.

The issue is similar with BSD-PAM/OpenPAM/libpam (and GNU Inetutils telnet and BSD telnet) and debug.

While these linkages do not occur out of the box, the change avoids the symbol conflicts in my use (which is a terminal server that supports multiple protocols), and the change would be necessary later if PAM support is added.

larsbrinkhoff commented 3 years ago

Thanks for explaining. The change is harmless enough, so I have nothing against it.