search

PDP-10 / supdup

Community maintained SUPDUP client for Unix
Other
16 stars 8 forks source link

Move definitions of ttyopt and ttyrol from supdup.h into supdupd.c. #33

Closed larsbrinkhoff closed 11 months ago

larsbrinkhoff commented 11 months ago

The latest commit - d3f5019 - tried to fix this problem:

cc -g -o supdup supdup.o charmap.o tcp.o chaos.o -lncurses
/usr/bin/ld: tcp.o:/home/runner/work/its/its/tools/supdup/supdup.h:98: multiple definition of `ttyopt'; supdup.o:/home/runner/work/its/its/tools/supdup/supdup.h:98: first defined here
/usr/bin/ld: tcp.o:/home/runner/work/its/its/tools/supdup/supdup.h:110: multiple definition of `ttyrol'; supdup.o:/home/runner/work/its/its/tools/supdup/supdup.h:110: first defined here

But the fix broke Chaosnet by not including supdup.h in chaos.c.

I believe the right fix is to move ttyopt and ttyrol into supdupd.c which is the only place they are used.