search

PDXBES / Rehab---nBCR-Tools

Pipe rehabilitation tracking and calculation tools
1 stars 1 forks source link

Bypass cost table in body of function #20

Open nmccullar opened 8 years ago

nmccullar commented 8 years ago

In COSTEST_Find_BypassPumpingUnitRate the table of costs is in the body of the function, instead of being looked up from a table, as with other functions.

Not a high priority change, but it would improve consistency, ease of changes and checks, and earn bonus points for style.

Edit: Same comment for traffic control unit costs

MisterGardner commented 8 years ago

This data can now be found in the table COSTEST_BypassPumpingUnitRates.

Function has been changed.

If you could rewrite the traffic function (using the same format as the rewrite of the bypass pumping) that would be awesome.

nmccullar commented 8 years ago

Let's hold off on this style issue until Gen4...trying to click the milestone...hmmm

Edit: got it!