PDXBES / Z-OLD-besasm-legacy

OLD-Legacy projects
0 stars 0 forks source link

Alternatives Toolkit will not allow DSC connection to links with certain valid LinkTypes #17

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Attempt to connect a DSC to a pipe with LinkType CO and the operation 
will fail.

Note that the fix for this issue has already been posted. I'm documenting 
here just so everyone can follow along with bug fixes as we move forward.

Due to a legacy decision, the Alternatives Toolkit uses LinkType as the 
source for determining allowable DSC connections. PipeFlowType would have 
been a more appropriate choice. However, LinkType is now ingrained in 
several processes that would be cumbersome to change, and is part of the 
alt_links schema.

The current work-around is as follows:
- Allowable LinkType values for alt_links are "C", "D" and "S" - A subset 
of the allowable PipeFlowType values in mst_links.
- For DSC connection purposes, the alt_links.LinkType is interpreted 
identical to mdl_link.PipeFlowType.
- In the DSCToolPad code the field alt_link.PipeFlowType is added to a 
temporary table, and the contents of alt_links.LinkType are copied into the 
temporary field. Subsequent code in DSCToolPad uses the 
alt_links.PipeFlowType field.
- If we embark on substantial future revisions to DSCToolPad or the 
alternative data structure the alt_links.LinkType field should be replaced 
with alt_links.PipeFlowType and all existing models should be patched. It 
is recommend that this effort not take place until there is a project need 
for major revisions to the data structure.

Original issue reported on code.google.com by john.hen...@gmail.com on 26 Jan 2010 at 8:40

GoogleCodeExporter commented 9 years ago
Resolved by adding temporary field alt_links.PipeFlowType when determining 
allowable 
connection types.

Original comment by john.hen...@gmail.com on 26 Jan 2010 at 8:42

GoogleCodeExporter commented 9 years ago
Added label

Original comment by ArnelMan...@gmail.com on 6 Oct 2010 at 12:20