search

PEC-CSS / acm-fun

Life is too short so have some fun
https://acm-fun.vercel.app/
5 stars 36 forks source link

Meme generator #13 #63

Closed GauravGupta993 closed 11 months ago

GauravGupta993 commented 12 months ago

13 Solved.

Made a new PR because some conflicts were appearing due to which I had to discard the commit that closed the previous PR.

vercel[bot] commented 12 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
acm-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2023 1:40pm
Ishwarendra commented 12 months ago

Also, there is CLS (Cumulative layout shift), on hovering submit button. You can take inspiration for button from Random Quote generator activity.

By CLS, I mean other div move due to increase in size of button. This side-effect is not good.

GauravGupta993 commented 12 months ago

Also, there is CLS (Cumulative layout shift), on hovering submit button. You can take inspiration for button from Random Quote generator activity.

By CLS, I mean other div move due to increase in size of button. This side-effect is not good.

Ok, will do so. Also, API used searches for memes from posts in Reddit communities. The community name for getting chess memes is r/chessmemes so putting chessmemes in the input box should work. Also, it produces related memes after clicking generate memes after clicking submit. Just after clicking submit it produces meme related to previous topic. To solve this what I can do is not generate any meme on clicking submit and generate meme only when clicking generate meme.