PEC-CSS / slowmokit

Library which can be used for machine learning in C++.
https://pec-css.github.io/slowmokit/
GNU General Public License v2.0
16 stars 16 forks source link

Multiclass Logistic Regression Model #80

Closed Sar-thak-3 closed 1 year ago

Sar-thak-3 commented 1 year ago
  • run the script as mentioned the README.md point 9 to format the spacing and everything properly Sir should i Run "./clang-format-all src/" this command directly in my vs code terminal?
harshjohar commented 1 year ago
  • run the script as mentioned the README.md point 9 to format the spacing and everything properly

Sir should i Run "./clang-format-all src/" this command directly in my vs code terminal?

If you have mac or linux then directly in terminal, but if you have windows, you gotta run this in git bash in the project root directory

Sar-thak-3 commented 1 year ago
  • run the script as mentioned the README.md point 9 to format the spacing and everything properly

Sir should i Run "./clang-format-all src/" this command directly in my vs code terminal?

If you have mac or linux then directly in terminal, but if you have windows, you gotta run this in git bash in the project root directory

Screenshot 2023-02-08 125736

harshjohar commented 1 year ago
  • run the script as mentioned the README.md point 9 to format the spacing and everything properly

Sir should i Run "./clang-format-all src/" this command directly in my vs code terminal?

If you have mac or linux then directly in terminal, but if you have windows, you gotta run this in git bash in the project root directory

Screenshot 2023-02-08 125736

hey sorry I forgot to add this in README.md, added now

For this you need to have clang-format binaries installed in the machine.

To do that, run the following in the terminal

# with npm (windows)
npm install -g clang-format
# you have to restart terminal in case of windows

# with homebrew (macos)
brew install clang-format

# linux (Ubuntu)
sudo apt install clang-format
Sar-thak-3 commented 1 year ago

Doesn't seem upto mark

Kindly review the changes

uttammittal02 commented 1 year ago

Doesn't seem upto mark

Kindly review the changes

Bro the code isn't readable...aake bta ke ja ki kya kr rha....variable names thode readable rakh....Add some comments too

uttammittal02 commented 1 year ago

@Sar-thak-3 Refer these docs for reference and add similar docs for your code. Also, do this for other models you pushed.