search

PECE-project / drupal-pece

PECE development repository
GNU General Public License v3.0
21 stars 28 forks source link

A contributor can create media-enhanced artifacts (such as Image artifact or Audio artifact) #378

Open mlncn opened 9 months ago

mlncn commented 9 months ago

Presently this has been upgraded to use Drupal core media, but if we are doing different content types for each kind of artifact (instead of #368 ) do we actually want any of the images, audio, or video uploaded with an artifact to end up in the media library?

If each item of media should stay bound to, and only to, an artifact, maybe we go back to the Drupal 7 approach of audio field, image field, etc (not a reference to a media entity)?

mlncn commented 9 months ago

Unrelated to those questions there's a weird technical glitch where an audio artifact or an image artifact will claim the media reference, and the configuration export will claim to update the expected file (config/field.field.node.pece_artifact_image.field_pece_media_image.yml or config/field.field.node.pece_artifact_audio.field_audio_media.yml) — but the files will be unchanged, because in fact they were correct to begin with, but somehow this was not reflected in the configuration import.

mlncn commented 7 months ago

From @lindsaypoirier in #392:

In the new version, we would like to have this fixed so that folks can add things from the media library (assuming that they can only see files associated with artifacts that have not be designated as private).

Exactly how complex that is, which will help determine if this is a worthwhile change, is being discussed in #392