search

PEERINGTestbed / client

PEERING client controller
https://peering.ee.columbia.edu
8 stars 17 forks source link

Community #18

Closed twabulldogg closed 6 years ago

twabulldogg commented 6 years ago

Changes made.

bschlinker commented 6 years ago

Ok. That's acceptable

On Oct 19, 2017 7:00 AM, "twabulldogg" notifications@github.com wrote:

@twabulldogg commented on this pull request.

In scripts/peering-prefix https://github.com/PEERINGTestbed/client/pull/18#discussion_r145708278:

@@ -109,6 +138,15 @@ c) fi communities+=($OPTARG) ;; +C)

  • for comm in $(echo $OPTARG | tr "," "\n")
  • do
  • if [[ $comm -gt 65535 || $comm -lt 1 ]] ; then

BIRD supports extended communities, but I chose to only implement the 16 bit version for the first version of the feature.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/PEERINGTestbed/client/pull/18#discussion_r145708278, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_tN5fC7YC0SVmZUIhP3LIx0Du9YRvtks5st1XfgaJpZM4PkdXI .