search

PEERINGTestbed / client

PEERING client controller
https://peering.ee.columbia.edu
8 stars 17 forks source link

Enable lxc dataplane #51

Closed MarcelHMendes closed 2 years ago

cunha commented 2 years ago

This looks good, just need testing after we merge the matching PR on the backend.

cunha commented 2 years ago

Well, maybe it doesn't make a difference for the ! -e expression. If shellcheck didn't complain, then I guess it's OK.

On Sun, Apr 3, 2022 at 6:27 PM Marcel Mendes @.***> wrote:

@.**** commented on this pull request.

In scripts/peering-prefix https://github.com/PEERINGTestbed/client/pull/51#discussion_r841279566:

 ;;

R) config_dataplane=0 ;; +M)

  • if [ ! -e "$ctxid_db" ] ; then

I'm using shellcheck, but it didn't warn me.

— Reply to this email directly, view it on GitHub https://github.com/PEERINGTestbed/client/pull/51#discussion_r841279566, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPO5ZA3HSW5CIQPQO7TH3VDIENJANCNFSM5MZ6CJFQ . You are receiving this because you commented.Message ID: @.***>