search

PEKennedy / cityquery

0 stars 0 forks source link

Peter - more bug fixes #39

Closed PEKennedy closed 1 year ago

PEKennedy commented 1 year ago

This fixes cases where there is no transform is provided in the cityquery file, such files will now be displayed properly. Also provides a theoretical speedup in constructing geometry in cases where a surface has only 3 or 4 vertices by skipping the Earcut algorithm (though this doesn't seem to make much difference in the end).

Also tested potential performance improvements using frameloop="demand" on the canvas component. This seems to be incompatible with the CameraControls component, so this optimization is removed for now.

Conner-H commented 1 year ago

seems to work fine, though when I removed the transform in montreal it didnt seem to display, but it did when I removed the transform in JsonPtCloud. May want to check their, though I could have just missed it

PEKennedy commented 1 year ago

seems to work fine, though when I removed the transform in montreal it didnt seem to display, but it did when I removed the transform in JsonPtCloud. May want to check their, though I could have just missed it

Looking at the montreal file, this seems to be because the vertices themselves are really large integer values, often 10s of kms out. I think this is probably fine, you can be the judge though.