PEM-- / meteor-helper

Meteor.js under Atom.io
http://pem-musing.blogspot.fr/2014/07/meteorjs-from-within-atomio-full-stack.html
MIT License
50 stars 9 forks source link

Difficult to read certain colors #18

Closed ghost closed 10 years ago

ghost commented 10 years ago

I personally find the blue and purple rather hard to read, but I can't seem to change these colors in the package settings. How can I change these?

meteor-pkg

PEM-- commented 10 years ago

Hi @CaptSaltyJack, Only the basic the color of stdout is configurable which was black over black when using console.log :sweat: . And, you're right, stderr via console.err are hard ro read (purple over black is terrible but the blue navy over black is even worse). Here, I simply reuse the colors provided by Meteor and putting them in a p tags thanks to ansi-to-html. This library has a configurable color scheme. I could export this variables is the settings to allow proper customization of console.err making them more readable.

Do you have any preferences that I could use as default?

ghost commented 10 years ago

I'd recommend #06f for the blue, and #b0f for the purple. Those are much more legible.

PEM-- commented 10 years ago

Thanks Cap, I will set these as default. Though, before releasing everything, I would like to test out a theme management with auto-detection. I got something scratching my back since this morning on it. I'll keep you posted.

ghost commented 10 years ago

Thanks Great work on the package, BTW!

PEM-- commented 10 years ago

Humm, its going to be longer than expected. Though ansi-to-html, it is unfinished. I'm currently PR it (very deeply).

PEM-- commented 10 years ago

Finally, it's a bit too late in France for creating a good PR on ansi-to-html :sleeping:. So I've removed it and make my custom formatter. Thus, it directly takes the color provided by the currently selected theme. I think it is more compelling and will be more appropriate to guys willing to change their default theme.

Hope that it will suit you :smile:. It is already deployed and available in the 0.16.0.

ghost commented 10 years ago

Thanks! Updated, and it's much easier to read now