search

PEM-- / meteor-helper

Meteor.js under Atom.io
http://pem-musing.blogspot.fr/2014/07/meteorjs-from-within-atomio-full-stack.html
MIT License
50 stars 9 forks source link

fix panel styling #21

Closed nyaaao closed 9 years ago

nyaaao commented 9 years ago

1: Scrollbars were always showed, making the panel look ugly, especially in dark mode 2: The panel contents were too close to the edge of the panel and looked a bit off 3: The status bar does not cover the panel's contents even without the bottom padding

before

after

PS: As you can see this does not fix all of the issues, just some of them.

PPS: I can submit those as separate PRs should you prefer so.

PEM-- commented 9 years ago

Hey, thanks for this PR! The panel has been seriously modified by Atom. I didn't have the time to fix it properly.

PEM-- commented 9 years ago

@nyaaao, I've just published the 0.18.1 with your PR and a fix on the panel header size. Should be good. Keep me updated :wink:

nyaaao commented 9 years ago

Great, thank you. I also have some deprecation-warning fixes, but I feel that, ultimately, we need to refactor a lot of the panel view code. I need to investigate more to come up with a complete solution.