search

PEM-- / meteor-helper

Meteor.js under Atom.io
http://pem-musing.blogspot.fr/2014/07/meteorjs-from-within-atomio-full-stack.html
MIT License
50 stars 9 forks source link

mongoOplogURL should be read from config #48

Closed jazeee closed 8 years ago

jazeee commented 8 years ago

Based on a bug I saw, I discovered that the code is not reading the Atom config for mongoOplogURL around line: https://github.com/PEM--/meteor-helper/blob/master/lib/meteor-helper-view.coffee#L135

I will create a PR.

As a workaround, one can add a parameter into mup.json such as "MONGO_OPLOG_URL": "mongodb://localhost:27017/..."

PEM-- commented 8 years ago

Hi @jazeee. Indeed, the setting was defined but not used properly. Thanks. Merging it and fixing another weird issue concerning the panel style.

jazeee commented 8 years ago

Excellent. Thanks! On Oct 27, 2015 1:46 AM, "Pierre-Eric Marchandet" notifications@github.com wrote:

Closed #48 https://github.com/PEM--/meteor-helper/issues/48 via a59effd https://github.com/PEM--/meteor-helper/commit/a59effda249e5eb625d139bf3c5b3bc68a9de8aa .

— Reply to this email directly or view it on GitHub https://github.com/PEM--/meteor-helper/issues/48#event-446430365.