search

PESTools / pestools

PESTools
12 stars 10 forks source link

ParSen Plots #15

Closed echristi closed 9 years ago

echristi commented 9 years ago

Plotting for ParSen class. See ParSen examples notebook for examples.

aleaf commented 9 years ago

Evan, looks good. Just a few comments.

drop_regul: is ‘regul’ pretty much standard for designating regularization observations? That has been true for the models I have worked with (where PEST has been setup by GWV or GFLOW). But maybe that isn't always the case. If we want to allow for other naming schemes, we could have the user specify a string for regul (or other "observation" groups to drop), and then all drop all observations with group names containing that string. Not exactly elegant, but can't think of a better way to do it.

Also kind of nitpicky, but probably good for consistency- according to PEP8, = sign for keywords or args shouldn't have extra spaces

def complex(real, imag=0.0):
    return magic(r=real, i=imag)
echristi commented 9 years ago

I updated to fit most of PEP8. Sometimes I leave lines long because they are just easier to read that way. It seems to happen often with pandas.

'regul' is the standard for PEST and required for all regularization observations so we should be good.

aleaf commented 9 years ago

cool sounds good. I am working on the phi contribution and location information stuff.

aleaf commented 9 years ago

Also, totally agree about not following PEP8 when it makes the code less readable. Even the PEP8 style guide recommends breaking with the style if it reduces readability.